Re: redundant gkey and key2tval in ltable.h (5.2.0-work3)

[HyperHacker <hyperhacker@...>]

On Wed, Jun 23, 2010 at 22:25, David Manura <dm.lua@math2.org> wrote:
> On Thu, Jun 24, 2010 at 12:13 AM, David Manura <dm.lua@math2.org> wrote:
>> Any reason not to eliminate key2tval(n) ?
>
> BTW, I would prefer some minimal comments in the source about macro
> parameter types, maybe like this:
>
>  /* t:Table*, i:int, n:Node*. */
>  #define gnode(t,i)    (&(t)->node[i])
>  #define gkey(n)       (&(n)->i_key.tvk)
>  #define gval(n)               (&(n)->i_val)
>  #define gnext(n)      ((n)->i_key.nk.next)
>

I would say the source needs a lot more comments overall.

-- 
Sent from my toaster.