[Date Prev][Date Next][Thread Prev][Thread Next]
[Date Index]
[Thread Index]
- Subject: Re: Announcing moonslice luv*, and lhttp_parser
- From: Tim Caswell <tim@...>
- Date: Wed, 10 Oct 2012 15:23:59 -0500
On Wed, Oct 10, 2012 at 3:20 PM, Petite Abeille
<petite.abeille@gmail.com> wrote:
>
> On Oct 10, 2012, at 10:11 PM, Petite Abeille <petite.abeille@gmail.com> wrote:
>
>> While on the subject of chunking, not sure about your chunk terminator… why 3 time CRLF? But then again, perhaps I'm missing the bigger picture and just being hasty :)
>>
>> https://github.com/creationix/moonslice-luv/blob/master/autoheaders.lua#L44
>
> Ah, yes, also… I don't think you can just return a chunked content to all clients… this is only supported by >= HTTP/1.1… try it with a plain HTTP/1.0 client and see what happen...
>
>
Good point! Thanks for the review. Could I talk you into filing
github issues and/or sending patches? If you don't have time, I
understand. I'll get to it when I can.
-Tim Caswell