Re: LuaSocket 3.0-rc1 now available

[Diego Nehab <diego@...>]

Can you open an issue at the github page? That way we can keep track of the suggestions and decide which ones will make it to the final release.

On Mon, Jun 17, 2013 at 12:34 AM, Enrico Tassi <gares@fettunta.org> wrote:

On Fri, Jun 14, 2013 at 07:37:23PM +0800, Diego Nehab wrote:
> Dear all,
>
> Over the past weeks there has been a lot of activity in the development of
> a new LuaSocket release. The main changes are support for IPv6 and for Lua
> 5.2.
>
> Please take a look at the project page at GitHub
>
>     https://github.com/diegonehab/luasocket

Cool!  May I suggest one thing?  Instead of having -D flags passed around
to define the visibility of symbols, have a .h file that does so, like in
http://gcc.gnu.org/wiki/Visibility

It's not radically different from your perspective (you move the idfefs
from the makefile to this .h) but makes things way simpler if one wants
to compile the sources with another build system.
In particular most of the files compile fine, since there are
default-value #ifndef for LUASOCKET_API etc, but not for all of them in
all files (like in serial.c), and even if they compile
-fvisibility=hidden + "extern" (the default value for LUASOCKET_API)
does not work well (i.e. no exported symbols in socket.so for example).

Cheers
--
Enrico Tassi