[Date Prev][Date Next][Thread Prev][Thread Next]
[Date Index]
[Thread Index]
- Subject: Re: double copy on string creation
- From: Roberto Ierusalimschy <roberto@...>
- Date: Fri, 4 Sep 2015 12:29:00 -0300
> Noticed that OP_CONCAT and LoadString in undump.c uses memcpy() twice if
> the resulting string is not already interned. Since the result length is
> known early the long string case can be quite easily optimized to copy data
> just once. Seems to slash 25+25 concat time by around 12%, probably more
> for longer strings. I see no reproducible regression in the short strings
> case.
That is a nice idea. We will try it. Many thanks,
-- Roberto
