Re: pthreads

[Sebastian Cato <seb.cato@...>]

Sorry, I didn't realize you are a package administrator for said package.

If you don't mind me asking, why don't you just add -lpthread to the
LDFLAGS in lua.spec?

On Thu, Aug 3, 2017 at 6:34 PM, Sebastian Cato <seb.cato@gmail.com> wrote:
> Hello,
>
> This should probably be addressed by the maintainer of the .spec file
> for the Lua package on Fedora, and not by Lua itself. system(3) is
> after all a standard C library function, and application packages that
> depends on the C library shouldn't care what various distributions do
> on their platforms.
>
> There is a BUG for it, though no meaningful activity yet:
> https://bugzilla.redhat.com/show_bug.cgi?id=1473680
>
> //Sebastian
>
> On Thu, Aug 3, 2017 at 5:48 PM, Tom Callaway <tcallawa@redhat.com> wrote:
>> Hi Lua folks,
>>
>> Recently, a bug came in for Fedora 26 saying that cgit was throwing
>> error messages, specifically:
>>
>> /var/www/cgi-bin/cgit: Relink `/lib64/liblua-5.3.so' with
>> `/lib64/libpthread.so.0' for IFUNC symbol `system'
>>
>> Now, it's worth pointing out that cgit wasn't actually failing at all,
>> it was just being noisy in the logs. That said, it seemed like an easy
>> fix, but in my experience, those are often the most controversial. :)
>>
>> I've attached a patch which changes configure.ac to check for pthread
>> support, using the ax_pthread.m4 from autoconf-archive. With this patch
>> applied to lua-5.3.4, pthreads are detected, cflags and ldflags are set
>> correctly, and cgit stops throwing this noise.
>>
>> If there is a more preferred way to handle use of pthreads here, please
>> let me know, as I do not want Fedora to diverge from lua upstream.
>>
>> Thanks,
>>
>> ~tom